cc: Add test for triggering deadline early when output surface is lost

cc: Add test for triggering deadline early when output surface is lost

R=brianderson@chromium.org
BUG=376463
TEST=SchedulerTest.TestTriggerDeadlineEarlyForLoseOutputSurface

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272459

[simonhong, 2014-05-22 03:21:26]

PTAL!

[brianderson, 2014-05-22 17:45:17]

Please associate this with a new or existing bug.

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine_unittest.cc (right):

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine_unittest.cc:1752:
TEST(SchedulerStateMachineTest, TestTriggerDeadlineEarlyForLoseOutputSurface) {
TestTriggerDeadlineEarlyOnLostOutputSurface

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine_unittest.cc:1771:
EXPECT_TRUE(state.ShouldTriggerBeginImplFrameDeadlineEarly());
Can you verify this is false before the output surface is lost?

[simonhong, 2014-05-22 20:28:52]

New issue is created for this.
Thanks for review!

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
File cc/scheduler/scheduler_state_machine_unittest.cc (right):

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine_unittest.cc:1752:
TEST(SchedulerStateMachineTest, TestTriggerDeadlineEarlyForLoseOutputSurface) {
On 2014/05/22 17:45:18, brianderson wrote:
> TestTriggerDeadlineEarlyOnLostOutputSurface

Done.

https://codereview.chromium.org/294473014/diff/1/cc/scheduler/scheduler_state...
cc/scheduler/scheduler_state_machine_unittest.cc:1771:
EXPECT_TRUE(state.ShouldTriggerBeginImplFrameDeadlineEarly());
On 2014/05/22 17:45:18, brianderson wrote:
> Can you verify this is false before the output surface is lost?

Done.

[brianderson, 2014-05-22 21:26:02]

lgtm

[simonhong, 2014-05-22 21:41:35]

The CQ bit was checked by simonhong@chromium.org

[commit-bot: I haz the power, 2014-05-22 21:42:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhong@chromium.org/294473014/20001

[commit-bot: I haz the power, 2014-05-23 05:40:32]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 06:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 06:09:48]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[simonhong, 2014-05-23 07:03:32]

The CQ bit was checked by simonhong@chromium.org

[commit-bot: I haz the power, 2014-05-23 07:08:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhong@chromium.org/294473014/20001

[commit-bot: I haz the power, 2014-05-23 09:50:58]

Change committed as 272459