Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 294473010: Improve compiler output for users who forget to include TypeConverter specializations. (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Improve compiler output for users who forget to include TypeConverter specializations. Currently when users forget to include their TypeConverter specializations, they get errors about various methods not defined in TypeConverter<x, y>. By removing the definition of the general template, users will get errors about incomplete type TypeConverter<x, y> used. TEST=None BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M mojo/public/cpp/bindings/type_converter.h View 2 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks! I decided to simply remove the ...
6 years, 7 months ago (2014-05-21 07:16:39 UTC) #1
darin (slow to review)
lgtm
6 years, 7 months ago (2014-05-21 07:25:19 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-21 07:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/294473010/1
6 years, 7 months ago (2014-05-21 07:28:03 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:00:33 UTC) #5
Message was sent while issue was closed.
Change committed as 272054

Powered by Google App Engine
This is Rietveld 408576698