Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 294473002: Allow extension crash notifications to replace each other. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Better patch. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 0d21871a71498f18d871daa1ae3a1cb05b63b93f..b359e3658eefbcba12299fb473bd42d32279cbc7 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -177,11 +177,11 @@ void NotificationImageReady(
// TODO(mukai, dewittj): remove this and switch to message center
// notifications.
DesktopNotificationService::AddIconNotification(
- GURL() /* empty origin */,
+ GURL("chrome://extension-crash"),
base::string16(),
message,
notification_icon,
- base::string16(),
+ base::UTF8ToUTF16(delegate->id()),
Andrew T Wilson (Slow) 2014/05/19 14:02:27 Maybe some inline comment that this is the replace
dewittj 2014/05/20 18:18:22 Done.
delegate.get(),
profile);
}

Powered by Google App Engine
This is Rietveld 408576698