Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Unified Diff: ios/clean/chrome/browser/ui/tools/BUILD.gn

Issue 2944703002: [ios clean] Adds ToolsMenu to Showcase. (Closed)
Patch Set: CL Feedback and extra cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tools/menu_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/tools/BUILD.gn
diff --git a/ios/clean/chrome/browser/ui/tools/BUILD.gn b/ios/clean/chrome/browser/ui/tools/BUILD.gn
index dafafc36ea5f064e511578413795ccbcd4cde50d..a63c8a02ef7cea586cbf9f0cab277b65360eb271 100644
--- a/ios/clean/chrome/browser/ui/tools/BUILD.gn
+++ b/ios/clean/chrome/browser/ui/tools/BUILD.gn
@@ -9,18 +9,14 @@ source_set("tools") {
"tools_mediator.h",
"tools_mediator.mm",
"tools_mediator_private.h",
- "tools_menu_model.h",
- "tools_menu_model.mm",
]
configs += [ "//build/config/compiler:enable_arc" ]
deps = [
+ ":tools_model",
":tools_ui",
"//base",
- "//components/strings",
- "//ios/chrome/app/strings",
- "//ios/chrome/browser/ui/tools_menu",
"//ios/clean/chrome/browser/ui/animators",
"//ios/clean/chrome/browser/ui/commands",
"//ios/clean/chrome/browser/ui/presenters",
@@ -32,13 +28,28 @@ source_set("tools") {
]
}
+source_set("tools_model") {
lpromero 2017/06/20 08:50:23 Why not just fold it into tools_ui? It's called mo
+ sources = [
+ "tools_menu_model.h",
+ "tools_menu_model.mm",
+ ]
+
+ configs += [ "//build/config/compiler:enable_arc" ]
+
+ deps = [
+ "//components/strings",
+ "//ios/chrome/app/strings",
+ "//ios/chrome/browser/ui/tools_menu",
+ "//ios/clean/chrome/browser/ui/commands",
+ ]
+}
+
source_set("tools_ui") {
sources = [
"menu_overflow_controls_stackview.h",
"menu_overflow_controls_stackview.mm",
"menu_view_controller.h",
"menu_view_controller.mm",
- "tools_actions.h",
"tools_consumer.h",
"tools_menu_item.h",
"tools_menu_item.mm",
« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tools/menu_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698