Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

Issue 2944703002: [ios clean] Adds ToolsMenu to Showcase. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/showcase/BUILD.gn » ('j') | ios/showcase/tools_menu/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
index 81e8c12339c5a4a35ba6e144275594fe36cfad10..e865e8ba82e9f5283a6011558ff3735f52e49bf3 100644
--- a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
@@ -237,6 +237,8 @@ const CGFloat kCloseButtonHeight = 44.0;
// CloseMenu Button Constraint.
[self.closeMenuButton.trailingAnchor
constraintEqualToAnchor:self.view.trailingAnchor],
+ [self.closeMenuButton.topAnchor
sczs 2017/06/16 20:46:34 Missing constraint that Showcase helped me notice
lpromero 2017/06/19 09:38:49 Awesome!
+ constraintEqualToAnchor:self.menuScrollView.topAnchor],
]];
}
« no previous file with comments | « no previous file | ios/showcase/BUILD.gn » ('j') | ios/showcase/tools_menu/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698