ios/showcase/tools_menu/BUILD.gn - Issue 2944703002: [ios clean] Adds ToolsMenu to Showcase.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/showcase/tools_menu/BUILD.gn

Issue 2944703002: [ios clean] Adds ToolsMenu to Showcase. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/tools/menu_view_controller.mm ('K') | « ios/showcase/core/showcase_model.mm ('k') | ios/showcase/tools_menu/sc_tools_coordinator.h » ('j') | ios/showcase/tools_menu/sc_tools_coordinator.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("tools_menu") {

	6 sources = [

	7 "sc_tools_coordinator.h",

	8 "sc_tools_coordinator.mm",

	9 ]

	10 deps = [

	11 "//base",

	12 "//ios/clean/chrome/browser/ui/commands",

	13 "//ios/clean/chrome/browser/ui/tools:tools",
	lpromero 2017/06/19 09:38:49 We shouldn't add this target as a dependency in Sh We shouldn't add this target as a dependency in Showcase. This is to get itemsModelList. Even if it has model in its name, should it be moved to the tools_ui target? Otherwise, in Showcase, we need to mock it, maybe even with bogus values. sczs 2017/06/19 19:44:38 I've created a new target for the model, I think i Show quoted text On 2017/06/19 09:38:49, lpromero wrote: > We shouldn't add this target as a dependency in Showcase. This is to get > itemsModelList. Even if it has model in its name, should it be moved to the > tools_ui target? > Otherwise, in Showcase, we need to mock it, maybe even with bogus values. I've created a new target for the model, I think it makes sense and it solves our problem. I guess I could also rename tools to tools_controller, I think it could be a nice "standard" to have across the app. WDYT?
	14 "//ios/clean/chrome/browser/ui/tools:tools_ui",

	15 "//ios/showcase/common",

	16 "//ui/base",

	17 ]

	18 libs = [ "UIKit.framework" ]

	19 configs += [ "//build/config/compiler:enable_arc" ]

	20 }

OLD	NEW