Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: milo/appengine/logdog/build.go

Issue 2944633003: [milo] Add BuildSummary and common models. (Closed)
Patch Set: add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/frontend/frontpage.go ('k') | milo/appengine/logdog/logDogBuild.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/logdog/build.go
diff --git a/milo/appengine/logdog/build.go b/milo/appengine/logdog/build.go
index 38fa0fe4a5a4da478bde4752e61aa97a36269a92..1cfca56c9aeb034b69a3573edbb6281faf58e884 100644
--- a/milo/appengine/logdog/build.go
+++ b/milo/appengine/logdog/build.go
@@ -203,24 +203,18 @@ func (b *ViewerURLBuilder) BuildLink(l *miloProto.Link) *resp.Link {
}
u := viewer.GetURL(server, b.Project, prefix.Join(types.StreamName(ls.Name)))
- link := resp.Link{
- Label: l.Label,
- URL: u,
- }
+ link := resp.NewLink(l.Label, u)
if link.Label == "" {
link.Label = ls.Name
}
- return &link
+ return link
case *miloProto.Link_Url:
- link := resp.Link{
- Label: l.Label,
- URL: t.Url,
- }
+ link := resp.NewLink(l.Label, t.Url)
if link.Label == "" {
link.Label = "unnamed"
}
- return &link
+ return link
default:
// Don't know how to render.
« no previous file with comments | « milo/appengine/frontend/frontpage.go ('k') | milo/appengine/logdog/logDogBuild.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698