Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: milo/appengine/frontend/buildbot_data.go

Issue 2944633003: [milo] Add BuildSummary and common models. (Closed)
Patch Set: add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/common/model/summary.go ('k') | milo/appengine/frontend/frontpage.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/frontend/buildbot_data.go
diff --git a/milo/appengine/frontend/buildbot_data.go b/milo/appengine/frontend/buildbot_data.go
index 168b2ff972de8f29fc10dddfb05f572e80b09a55..20d66cac80ecb5392f290a9ea364195f15c8a70c 100644
--- a/milo/appengine/frontend/buildbot_data.go
+++ b/milo/appengine/frontend/buildbot_data.go
@@ -40,6 +40,7 @@ func buildbotBuildTestData() []common.TestBundle {
// buildbotBuilderTestData returns sample test data for builder pages.
func buildbotBuilderTestData() []common.TestBundle {
+ l := resp.NewLink("Some current build", "https://some.url/path")
return []common.TestBundle{
{
Description: "Basic Test no builds",
@@ -61,31 +62,13 @@ func buildbotBuilderTestData() []common.TestBundle {
Busy: 8,
},
CurrentBuilds: []*resp.BuildSummary{
- {
- Link: &resp.Link{
- URL: "https://some.url/path",
- Label: "Some current build",
- },
- Revision: "deadbeef",
- },
+ {Link: l, Revision: "deadbeef"},
},
PendingBuilds: []*resp.BuildSummary{
- {
- Link: &resp.Link{
- URL: "https://some.url/path",
- Label: "Some current build",
- },
- Revision: "deadbeef",
- },
+ {Link: l, Revision: "deadbeef"},
},
FinishedBuilds: []*resp.BuildSummary{
- {
- Link: &resp.Link{
- URL: "https://some.url/path",
- Label: "Some current build",
- },
- Revision: "deadbeef",
- },
+ {Link: l, Revision: "deadbeef"},
},
},
},
« no previous file with comments | « milo/appengine/common/model/summary.go ('k') | milo/appengine/frontend/frontpage.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698