Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: milo/appengine/buildbucket/common.go

Issue 2944633003: [milo] Add BuildSummary and common models. (Closed)
Patch Set: add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbucket/builder.go ('k') | milo/appengine/common/model/build_summary.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbucket/common.go
diff --git a/milo/appengine/buildbucket/common.go b/milo/appengine/buildbucket/common.go
index 0347acaba8b7f508a9b7978327370a7d4c710335..bdd7fabf97f8c0cb0117b877c4e22bd1b5454057 100644
--- a/milo/appengine/buildbucket/common.go
+++ b/milo/appengine/buildbucket/common.go
@@ -15,6 +15,7 @@ import (
"github.com/luci/luci-go/common/api/buildbucket/buildbucket/v1"
"github.com/luci/luci-go/common/api/buildbucket/swarmbucket/v1"
"github.com/luci/luci-go/milo/api/resp"
+ "github.com/luci/luci-go/milo/appengine/common/model"
"github.com/luci/luci-go/server/auth"
)
@@ -70,29 +71,29 @@ func newBuildbucketClient(c context.Context, server string) (*buildbucket.Servic
}
// parseStatus converts a buildbucket build status to resp.Status.
-func parseStatus(build *buildbucket.ApiCommonBuildMessage) (resp.Status, error) {
+func parseStatus(build *buildbucket.ApiCommonBuildMessage) (model.Status, error) {
switch build.Status {
case StatusScheduled:
- return resp.NotRun, nil
+ return model.NotRun, nil
case StatusStarted:
- return resp.Running, nil
+ return model.Running, nil
case StatusCompleted:
switch build.Result {
case "SUCCESS":
- return resp.Success, nil
+ return model.Success, nil
case "FAILURE":
switch build.FailureReason {
case "BUILD_FAILURE":
- return resp.Failure, nil
+ return model.Failure, nil
default:
- return resp.InfraFailure, nil
+ return model.InfraFailure, nil
}
case "CANCELED":
- return resp.InfraFailure, nil
+ return model.InfraFailure, nil
default:
return 0, fmt.Errorf("unexpected buildbucket build result %q", build.Result)
@@ -113,16 +114,16 @@ func getChangeList(
case "rietveld":
if prop.RietveldURL != "" && prop.Issue != 0 {
result = &resp.Commit{
- RequestRevision: &resp.Link{Label: prop.Revision},
- Changelist: &resp.Link{
- Label: fmt.Sprintf("Rietveld CL %d", prop.Issue),
- URL: fmt.Sprintf("%s/%d/#ps%d", prop.RietveldURL, prop.Issue, prop.PatchSet),
- },
+ RequestRevision: resp.NewLink(prop.Revision, ""),
+ Changelist: resp.NewLink(
+ fmt.Sprintf("Rietveld CL %d", prop.Issue),
+ fmt.Sprintf("%s/%d/#ps%d", prop.RietveldURL, prop.Issue, prop.PatchSet),
+ ),
}
if resultDetails.Properties.GotRevision != "" {
// TODO(hinoka): Figure out the full URL for these revisions, add it
// to the URL field.
- result.Revision = &resp.Link{Label: resultDetails.Properties.GotRevision}
+ result.Revision = resp.NewLink(resultDetails.Properties.GotRevision, "")
}
}
@@ -133,11 +134,10 @@ func getChangeList(
path = fmt.Sprintf("%d/%d", prop.GerritPatchIssue, prop.GerritPatchSet)
}
result = &resp.Commit{
- Changelist: &resp.Link{
- Label: fmt.Sprintf("Gerrit CL %d", prop.GerritPatchIssue),
- URL: fmt.Sprintf(
- "%s/c/%s", prop.GerritPatchURL, path),
- },
+ Changelist: resp.NewLink(
+ fmt.Sprintf("Gerrit CL %d", prop.GerritPatchIssue),
+ fmt.Sprintf("%s/c/%s", prop.GerritPatchURL, path),
+ ),
}
}
}
« no previous file with comments | « milo/appengine/buildbucket/builder.go ('k') | milo/appengine/common/model/build_summary.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698