Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: milo/appengine/buildbucket/buckets.go

Issue 2944633003: [milo] Add BuildSummary and common models. (Closed)
Patch Set: add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/structs.go ('k') | milo/appengine/buildbucket/builder.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbucket/buckets.go
diff --git a/milo/appengine/buildbucket/buckets.go b/milo/appengine/buildbucket/buckets.go
index 5b65cd5bb3a21113ff367e05660625c7b96a16e5..0243b6170f2a7def91d4a8cc2f99c6fcfa9af1ed 100644
--- a/milo/appengine/buildbucket/buckets.go
+++ b/milo/appengine/buildbucket/buckets.go
@@ -22,10 +22,7 @@ func GetAllBuilders(c context.Context) (*resp.CIService, error) {
}
result := &resp.CIService{
Name: "Swarmbucket",
- Host: &resp.Link{
- Label: bucketSettings.Name,
- URL: "https://" + bucketSettings.Host,
- },
+ Host: resp.NewLink(bucketSettings.Name, "https://"+bucketSettings.Host),
}
client, err := newSwarmbucketClient(c, bucketSettings.Host)
if err != nil {
@@ -42,10 +39,8 @@ func GetAllBuilders(c context.Context) (*resp.CIService, error) {
group := resp.BuilderGroup{Name: bucket.Name}
group.Builders = make([]resp.Link, len(bucket.Builders))
for j, builder := range bucket.Builders {
- group.Builders[j] = resp.Link{
- Label: builder.Name,
- URL: fmt.Sprintf("/buildbucket/%s/%s", bucket.Name, builder.Name),
- }
+ group.Builders[j] = *resp.NewLink(
+ builder.Name, fmt.Sprintf("/buildbucket/%s/%s", bucket.Name, builder.Name))
}
result.BuilderGroups[i] = group
}
« no previous file with comments | « milo/appengine/buildbot/structs.go ('k') | milo/appengine/buildbucket/builder.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698