milo/appengine/backend/git/gitiles.go - Issue 2944633003: [milo] Add BuildSummary and common models.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/backend/git/gitiles.go

Issue 2944633003: [milo] Add BuildSummary and common models. (Closed)

Patch Set: add comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/backend/git/gitiles.go

diff --git a/milo/appengine/backend/git/gitiles.go b/milo/appengine/backend/git/gitiles.go

index 14ac81f0d95b7b853607c3644b4399c7ec8e1f7c..e854160a8befb516cb01e9a96249b217d9953127 100644

--- a/milo/appengine/backend/git/gitiles.go

+++ b/milo/appengine/backend/git/gitiles.go

@@ -113,10 +113,7 @@ func GetCommits(c context.Context, repoURL, treeish string, limit int) ([]resp.C

AuthorName: log.Author.Name,

AuthorEmail: log.Author.Email,

Repo: repoURL,

- Revision: &resp.Link{

- Label: log.Commit,

- URL: repoURL + "/+/" + log.Commit,

- },

+ Revision: resp.NewLink(log.Commit, repoURL+"/+/"+log.Commit),

Description: log.Message,

Title: strings.SplitN(log.Message, "\n", 2)[0],

// TODO(hinoka): Fill in the rest of resp.Commit and add those details

« no previous file with comments | « milo/api/resp/verbosity_string.go ('k') | milo/appengine/buildbot/build.go » ('j') | no next file with comments »