Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: content/common/sandbox_mac.mm

Issue 2944623003: Call SetApplicationIsDaemon() in V2 sandbox. (Closed)
Patch Set: Get rid of extra private Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/sandbox_mac.h ('k') | content/renderer/renderer_v2.sb » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_mac.mm
diff --git a/content/common/sandbox_mac.mm b/content/common/sandbox_mac.mm
index 256aa8158e942638aa023ac041660ee81b2080c4..daf9337206ebda512cb95b49fdc47aeae87ec936 100644
--- a/content/common/sandbox_mac.mm
+++ b/content/common/sandbox_mac.mm
@@ -170,11 +170,7 @@ void Sandbox::SandboxWarmup(int sandbox_type) {
CGSSetDenyWindowServerConnections(true);
CGSShutdownServerConnections();
- // Allow the process to continue without a LaunchServices ASN. The
- // INIT_Process function in HIServices will abort if it cannot connect to
- // launchservicesd to get an ASN. By setting this flag, HIServices skips
- // that.
- SetApplicationIsDaemon(true);
+ LaunchServicesNotAvailable();
}
}
@@ -317,4 +313,13 @@ base::FilePath Sandbox::GetCanonicalSandboxPath(const base::FilePath& path) {
return base::FilePath(canonical_path);
}
+// static
+void Sandbox::LaunchServicesNotAvailable() {
+ // Allow the process to continue without a LaunchServices ASN. The
+ // INIT_Process function in HIServices will abort if it cannot connect to
+ // launchservicesd to get an ASN. By setting this flag, HIServices skips
+ // that.
+ SetApplicationIsDaemon(true);
Robert Sesek 2017/06/16 19:28:59 I think this call should just move to https://cs.c
Greg K 2017/06/16 20:32:11 Done.
+}
+
} // namespace content
« no previous file with comments | « content/common/sandbox_mac.h ('k') | content/renderer/renderer_v2.sb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698