Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: tests/standalone/io/skipping_dart2js_compilations_test.dart

Issue 2944543002: [Gardening] fixing bad test. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // OtherResources=skipping_dart2js_compilations_helper.dart 5 // OtherResources=skipping_dart2js_compilations_helper.dart
6 6
7 /* 7 /*
8 * This test makes sure that the "skipping Dart2Js compilations if the output is 8 * This test makes sure that the "skipping Dart2Js compilations if the output is
9 * already up to date" feature does work as it should. 9 * already up to date" feature does work as it should.
10 * Therefore this test ensures that compilations are only skipped if the last 10 * Therefore this test ensures that compilations are only skipped if the last
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 Expect.isTrue(output.stdout.length == 0); 140 Expect.isTrue(output.stdout.length == 0);
141 Expect.isTrue( 141 Expect.isTrue(
142 new File(fileUtils.scriptOutputPath.toNativePath()).existsSync()); 142 new File(fileUtils.scriptOutputPath.toNativePath()).existsSync());
143 } else { 143 } else {
144 Expect.isFalse( 144 Expect.isFalse(
145 new File(fileUtils.scriptOutputPath.toNativePath()).existsSync()); 145 new File(fileUtils.scriptOutputPath.toNativePath()).existsSync());
146 } 146 }
147 } 147 }
148 } 148 }
149 149
150 runner.Command makeCompilationCommand(String testName, FileUtils fileUtils) { 150 Command makeCompilationCommand(String testName, FileUtils fileUtils) {
151 var config = new options.OptionsParser().parse(['--timeout', '2'])[0]; 151 var config = new options.OptionsParser().parse(['--timeout', '2'])[0];
152 var createFileScript = Platform.script 152 var createFileScript = Platform.script
153 .resolve('skipping_dart2js_compilations_helper.dart') 153 .resolve('skipping_dart2js_compilations_helper.dart')
154 .toFilePath(); 154 .toFilePath();
155 var executable = Platform.executable; 155 var executable = Platform.executable;
156 var arguments = [createFileScript, fileUtils.scriptOutputPath.toNativePath()]; 156 var arguments = [createFileScript, fileUtils.scriptOutputPath.toNativePath()];
157 var bootstrapDeps = [Uri.parse("file://${fileUtils.testSnapshotFilePath}")]; 157 var bootstrapDeps = [Uri.parse("file://${fileUtils.testSnapshotFilePath}")];
158 return Command.compilation('dart2js', fileUtils.testJsFilePath.toNativePath(), 158 return Command.compilation('dart2js', fileUtils.testJsFilePath.toNativePath(),
159 false, bootstrapDeps, executable, arguments, {}); 159 false, bootstrapDeps, executable, arguments, {});
160 } 160 }
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 throw error; 244 throw error;
245 }).then((_) { 245 }).then((_) {
246 cleanup(); 246 cleanup();
247 }); 247 });
248 } 248 }
249 249
250 // We need to wait some time to make sure that the files we 'touch' get a 250 // We need to wait some time to make sure that the files we 'touch' get a
251 // bigger timestamp than the old ones 251 // bigger timestamp than the old ones
252 new Timer(new Duration(seconds: 1), touchFilesAndRunTests); 252 new Timer(new Duration(seconds: 1), touchFilesAndRunTests);
253 } 253 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698