Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: base/functional_unittest.cc

Issue 2944523002: Improving flat containers interface. (Closed)
Patch Set: Review, round 4. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/functional.h"
6
7 #include "base/containers/container_test_utils.h"
danakj 2017/06/26 19:33:12 this file should be in base/test/, especially if i
dyaroshev 2017/06/26 22:40:43 Done.
8 #include "base/containers/flat_tree.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 namespace base {
12
danakj 2017/06/26 19:33:12 nit: remove whitespace
dyaroshev 2017/06/26 22:40:43 Not applicable.
13 namespace {
14
15 TEST(Functional, Less) {
16 using ExplicitInt = base::MoveOnlyInt;
17 EXPECT_TRUE(base::less()(ExplicitInt(3), 4));
18 EXPECT_FALSE(base::less()(4, ExplicitInt(3)));
19 EXPECT_TRUE(base::less()(3, 4));
20
21 static_assert(base::internal::IsTransparentCompare<base::less>::value, "");
22 }
23
24 } // namespace
25
danakj 2017/06/26 19:33:12 nit: remove whitespace
dyaroshev 2017/06/26 22:40:43 Not applicable.
26 } // namespace base
OLDNEW
« base/functional.h ('K') | « base/functional.h ('k') | base/template_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698