base/functional.h - Issue 2944523002: Improving flat containers interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/functional.h

Issue 2944523002: Improving flat containers interface. (Closed)

Patch Set: Review, round 4. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.
	danakj 2017/06/26 19:33:12 Can this go in template_util.h? We haven't reprodu Can this go in template_util.h? We haven't reproduced the STL header structure in base and I'm not sure that we want to start now. dyaroshev 2017/06/26 22:40:42 Done Show quoted text On 2017/06/26 at 19:33:12, danakj wrote: > Can this go in template_util.h? We haven't reproduced the STL header structure in base and I'm not sure that we want to start now. Done
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_FUNCTIONAL_H_

	6 #define BASE_FUNCTIONAL_H_

	7

	8 #include <functional>

	9 #include <utility>

	10

	11 namespace base {

	12

	13 // std::less<> from C++14.

	14 // Needed for improved flat containers API.
	danakj 2017/06/26 19:33:12 remove this line remove this line dyaroshev 2017/06/26 22:40:42 Done. Show quoted text On 2017/06/26 at 19:33:12, danakj wrote: > remove this line Done.
	15

	16 struct less {

	17 template <typename T, typename U>

	18 constexpr auto operator()(T&& lhs, U&& rhs) const

	19 -> decltype(std::forward<T>(lhs) < std::forward<U>(rhs)) {

	20 return std::forward<T>(lhs) < std::forward<U>(rhs);

	21 }

	22

	23 using is_transparent = int;
	danakj 2017/06/26 19:33:12 Refer to transparent docs here also please Refer to transparent docs here also please dyaroshev 2017/06/26 22:40:42 Done Show quoted text On 2017/06/26 at 19:33:12, danakj wrote: > Refer to transparent docs here also please Done
	24 };

	25

	26 } // base
	danakj 2017/06/26 19:33:12 namespace base namespace base dyaroshev 2017/06/26 22:40:42 Not applicable. Show quoted text On 2017/06/26 at 19:33:12, danakj wrote: > namespace base Not applicable.
	27

	28 #endif // BASE_FUNCTIONAL_H_

OLD	NEW

« base/containers/flat_tree.h ('K') | « base/containers/flat_tree_unittest.cc ('k') | base/functional_unittest.cc » ('j') | base/functional_unittest.cc » ('J')