Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2944483003: Fail more helpfully when invoking a null native function. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Fail more helpfully when invoking a null native function. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/324078ab308db3c6153cc4436e5b5fdd4c94f209

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/vm/native_entry.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 6 months ago (2017-06-16 23:25:01 UTC) #2
siva
lgtm
3 years, 5 months ago (2017-07-13 00:24:54 UTC) #3
rmacnak
3 years, 5 months ago (2017-07-13 16:55:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
324078ab308db3c6153cc4436e5b5fdd4c94f209 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698