Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2944483002: Allow enabling --causal-async-stacks in AOT. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, tvolkert
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M runtime/vm/flag_list.h View 2 chunks +8 lines, -1 line 0 comments Download
A tests/standalone/causal_async_stack_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-15 17:49:56 UTC) #2
siva
lgtm https://codereview.chromium.org/2944483002/diff/1/runtime/vm/flag_list.h File runtime/vm/flag_list.h (right): https://codereview.chromium.org/2944483002/diff/1/runtime/vm/flag_list.h#newcode22 runtime/vm/flag_list.h:22: // Don't use USING_PRODUCT outside of this file. ...
3 years, 6 months ago (2017-06-15 18:03:25 UTC) #3
rmacnak
https://codereview.chromium.org/2944483002/diff/1/runtime/vm/flag_list.h File runtime/vm/flag_list.h (right): https://codereview.chromium.org/2944483002/diff/1/runtime/vm/flag_list.h#newcode22 runtime/vm/flag_list.h:22: // Don't use USING_PRODUCT outside of this file. On ...
3 years, 6 months ago (2017-06-15 18:09:19 UTC) #4
rmacnak
3 years, 6 months ago (2017-06-15 18:09:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
26336b47a309c7f7575654aeaf2738fcc730714b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698