Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2944463002: Use quiver directly, and update README.google. This is so that (Closed)

Created:
3 years, 6 months ago by jcollins
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use quiver directly, and update README.google. This is so that we don't have to fork quiver_hashcode as well. BUG= R=whesse@google.com Committed: a9ef1cdd99a7f4475418bcaff29dab09a31ddead

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M README.google View 1 chunk +2 lines, -1 line 0 comments Download
M lib/tuple.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jcollins
Tested by running unit tests locally and integrating this as a dependency of dartdoc, checking ...
3 years, 6 months ago (2017-06-15 15:16:58 UTC) #2
Bill Hesse
LGTM. Hooray!
3 years, 6 months ago (2017-06-15 15:17:48 UTC) #3
jcollins
3 years, 6 months ago (2017-06-15 15:18:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9ef1cdd99a7f4475418bcaff29dab09a31ddead (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698