Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/android/vr_shell/vr_shell_gl.cc

Issue 2944453002: VR: Stop sending mouse moves while mouse is down to content window. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/vr_shell_gl.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell_gl.cc b/chrome/browser/android/vr_shell/vr_shell_gl.cc
index ff74f29b522e09c585e8e01fef0f04715324ee98..dac537588e33375a8768c88be4d185ef609eb8c2 100644
--- a/chrome/browser/android/vr_shell/vr_shell_gl.cc
+++ b/chrome/browser/android/vr_shell/vr_shell_gl.cc
@@ -744,6 +744,12 @@ void VrShellGl::SendHoverMove(const gfx::PointF& target_point,
if (!hover_target_)
return;
if (hover_target_->fill() == Fill::CONTENT) {
+ // TODO(mthiesse, vollick): Content is currently way to sensitive to mouse
Ian Vollick 2017/06/15 15:09:57 nit: too.
+ // moves for how noisy the controller is. It's almost impossible to click a
+ // link without unintentionally starting a drag event. For this reason we
+ // disable mouse moves, only delivering a down and up event.
+ if (in_click_)
+ return;
SendGestureToContent(MakeMouseEvent(blink::WebInputEvent::kMouseMove,
NowSeconds(), local_point_pixels,
in_click_));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698