Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: ios/chrome/browser/ui/stack_view/card_set.h

Issue 2944443003: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:stack_view to ARC. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/stack_view/card_set.h
diff --git a/ios/chrome/browser/ui/stack_view/card_set.h b/ios/chrome/browser/ui/stack_view/card_set.h
index 030e6e358b898e3a0970204507fa0b1ebea920f5..e0fa2356f8ff678d7aa91da4f75afab43401948f 100644
--- a/ios/chrome/browser/ui/stack_view/card_set.h
+++ b/ios/chrome/browser/ui/stack_view/card_set.h
@@ -47,22 +47,22 @@ struct LayoutRect;
@interface CardSet : NSObject
// The layout manager for the set.
// TODO(stuartmorgan): See if this can reasonably be internalized.
-@property(nonatomic, readonly) CardStackLayoutManager* stackModel;
+@property(weak, nonatomic, readonly) CardStackLayoutManager* stackModel;
stkhapugin 2017/06/16 13:17:50 It seems like these four properties are all strong
marq (ping after 24h) 2017/06/19 10:34:24 I'll make them not-weak, but I don't want to fiddl
// An array of StackCards in the same order as the tabs in the tab model.
-@property(nonatomic, readonly) NSArray* cards;
+@property(weak, nonatomic, readonly) NSArray* cards;
// The card corresponding to the currently selected tab in the tab model.
// Setting this property will change the selection in the tab model.
-@property(nonatomic, assign, readwrite) StackCard* currentCard;
+@property(nonatomic, weak, readwrite) StackCard* currentCard;
// Set to the card that is currently animating closed, if any.
-@property(nonatomic, assign, readwrite) StackCard* closingCard;
+@property(nonatomic, weak, readwrite) StackCard* closingCard;
// The view that cards should be displayed in. Changing the display view will
// remove cards from the previous view, but they will not be re-displayed in the
// new view without a call to updateCardVisibilities.
-@property(nonatomic, retain, readwrite) UIView* displayView;
+@property(nonatomic, strong, readwrite) UIView* displayView;
// The side on which the close button should be displayed.
@property(nonatomic, readonly) CardCloseButtonSide closeButtonSide;
// The object to be notified about addition and removal of cards.
-@property(nonatomic, assign, readwrite) id<CardSetObserver> observer;
+@property(nonatomic, weak, readwrite) id<CardSetObserver> observer;
// While YES, changes to the tab model will not affect the card stack. When
// this is changed back to NO, the card stack will be completely rebuilt, so
// this should be used very carefully.

Powered by Google App Engine
This is Rietveld 408576698