[kernel] Add TokenPosition to AllocateObject, fix some cc tests

runtime/vm/profiler_service.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/profiler_service.h"
 
 #include "vm/growable_array.h"
 #include "vm/hash_map.h"
 #include "vm/log.h"
 #include "vm/malloc_hooks.h"
@@ skipping 2660 matching lines @@
   if (function.IsNull()) {
     // No function.
     return NULL;
   }
   Zone* zone = Thread::Current()->zone();
   const Script& script = Script::Handle(zone, function.script());
   if (script.IsNull()) {
     // No script.
     return NULL;
   }
-  const TokenStream& token_stream = TokenStream::Handle(zone, script.tokens());
-  if (token_stream.IsNull()) {
-    // No token position.
-    return NULL;
-  }
   ProfileFunctionSourcePosition pfsp(TokenPosition::kNoSource);
   if (!func->GetSinglePosition(&pfsp)) {
     // Not exactly one source position.
     return NULL;
   }
   TokenPosition token_pos = pfsp.token_pos();
   if (!token_pos.IsSourcePosition()) {
     // Not a location in a script.
     return NULL;
   }
   if (token_pos.IsSynthetic()) {
     token_pos = token_pos.FromSynthetic();
   }
-  TokenStream::Iterator iterator(zone, token_stream, token_pos);
-  const String& str = String::Handle(zone, iterator.CurrentLiteral());
-  if (str.IsNull()) {
-    return NULL;
+
+  if (script.kind() == RawScript::kKernelTag) {

[Vyacheslav Egorov (Google), 2017/06/16 11:09:18]

Please update CL description to include description of this change, because it
does not fit "Add TokenPosition to AllocateObject" description. 

[jensj, 2017/06/16 11:39:07]

"fix some cc tests" isn't descriptive enough?

[Kevin Millikin (Google), 2017/06/21 06:50:43]

I would probably factor out the common code from the two cases and just put the
different parts in the conditional branches:

String& str = String::Handle(zone);
if (script.kind() == ...) {
  ...
  str = script.GetSnippet(...);
} else {
  const TokenStream& ...
  if (!token_stream.IsNull()) {
    TokenStream::Iterator ...
    str = iterator.CurrentLiteral());
  }
}

return str.IsNull() ? NULL : str.ToCString();

+    intptr_t line = 0, column = 0, token_len = 0;
+    script.GetTokenLocation(token_pos, &line, &column, &token_len);
+    const String& str = String::Handle(
+        zone, script.GetSnippet(line, column, line, column + token_len));
+    if (str.IsNull()) {
+      return NULL;
+    }
+    return str.ToCString();
+  } else {
+    const TokenStream& token_stream =
+        TokenStream::Handle(zone, script.tokens());
+    if (token_stream.IsNull()) {
+      // No token position.
+      return NULL;
+    }
+    TokenStream::Iterator iterator(zone, token_stream, token_pos);
+    const String& str = String::Handle(zone, iterator.CurrentLiteral());
+    if (str.IsNull()) {
+      return NULL;
+    }
+    return str.ToCString();
   }
-  return str.ToCString();
 }
 
 bool ProfileTrieWalker::Down() {
   if ((current_ == NULL) || (current_->NumChildren() == 0)) {
     return false;
   }
   parent_ = current_;
   current_ = current_->At(0);
   return true;
 }
@@ skipping 163 matching lines @@
   // Disable thread interrupts while processing the buffer.
   DisableThreadInterruptsScope dtis(thread);
 
   ClearProfileVisitor clear_profile(isolate);
   sample_buffer->VisitSamples(&clear_profile);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart