[kernel] Add TokenPosition to AllocateObject, fix some cc tests

runtime/vm/kernel_binary_flowgraph.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_binary_flowgraph.h"
 
 #include "vm/compiler.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 
@@ skipping 4560 matching lines @@
     const TypeArguments& type_arguments) {
   return flow_graph_builder_->TranslateInstantiatedTypeArguments(
       type_arguments);
 }
 
 Fragment StreamingFlowGraphBuilder::StrictCompare(Token::Kind kind,
                                                   bool number_check) {
   return flow_graph_builder_->StrictCompare(kind, number_check);
 }
 
-Fragment StreamingFlowGraphBuilder::AllocateObject(const dart::Class& klass,
+Fragment StreamingFlowGraphBuilder::AllocateObject(TokenPosition position,
+                                                   const dart::Class& klass,
                                                    intptr_t argument_count) {
-  return flow_graph_builder_->AllocateObject(klass, argument_count);
+  return flow_graph_builder_->AllocateObject(position, klass, argument_count);
 }
 
 Fragment StreamingFlowGraphBuilder::InstanceCall(TokenPosition position,
                                                  const dart::String& name,
                                                  Token::Kind kind,
                                                  intptr_t argument_count,
                                                  const Array& argument_names,
                                                  intptr_t num_args_checked) {
   return flow_graph_builder_->InstanceCall(position, name, kind, argument_count,
                                            argument_names, num_args_checked);
@@ skipping 618 matching lines @@
   // In that case we'll make an instance and pass it as first argument.
   //
   // TODO(27590): Get rid of this after we're using core libraries compiled
   // into Kernel.
   if (target.IsGenerativeConstructor()) {
     if (klass.NumTypeArguments() > 0) {
       const TypeArguments& type_arguments =
           PeekArgumentsInstantiatedType(klass);
       instructions += TranslateInstantiatedTypeArguments(type_arguments);
       instructions += PushArgument();
-      instructions += AllocateObject(klass, 1);
+      instructions += AllocateObject(position, klass, 1);
     } else {
-      instructions += AllocateObject(klass, 0);
+      instructions += AllocateObject(position, klass, 0);
     }
 
     instance_variable = MakeTemporary();
 
     instructions += LoadLocal(instance_variable);
     instructions += PushArgument();
   } else if (target.IsFactory()) {
     // The VM requires currently a TypeArguments object as first parameter for
     // every factory constructor :-/ !
     //
@@ skipping 97 matching lines @@
       TypeArguments& canonicalized_type_arguments =
           TypeArguments::ZoneHandle(Z, type.arguments());
       canonicalized_type_arguments =
           canonicalized_type_arguments.Canonicalize();
       instructions += Constant(canonicalized_type_arguments);
     } else {
       instructions += TranslateInstantiatedTypeArguments(type_arguments);
     }
 
     instructions += PushArgument();
-    instructions += AllocateObject(klass, 1);
+    instructions += AllocateObject(position, klass, 1);
   } else {
-    instructions += AllocateObject(klass, 0);
+    instructions += AllocateObject(position, klass, 0);
   }
   LocalVariable* variable = MakeTemporary();
 
   instructions += LoadLocal(variable);
   instructions += PushArgument();
 
   Array& argument_names = Array::ZoneHandle(Z);
   intptr_t argument_count;
   instructions +=
       BuildArguments(&argument_names, &argument_count);  // read arguments.
@@ skipping 556 matching lines @@
       Z, klass.LookupConstructorAllowPrivate(
              H.DartSymbol("_AssertionError._create")));
   ASSERT(!constructor.IsNull());
 
   const dart::String& url = H.DartString(
       parsed_function()->function().ToLibNamePrefixedQualifiedCString(),
       Heap::kOld);
 
   // Create instance of _AssertionError
   Fragment otherwise_fragment(otherwise);
-  otherwise_fragment += AllocateObject(klass, 0);
+  otherwise_fragment += AllocateObject(TokenPosition::kNoSource, klass, 0);
   LocalVariable* instance = MakeTemporary();
 
   // Call _AssertionError._create constructor.
   otherwise_fragment += LoadLocal(instance);
   otherwise_fragment += PushArgument();  // this
 
   otherwise_fragment += Constant(H.DartString("<no message>", Heap::kOld));
   otherwise_fragment += PushArgument();  // failedAssertion
 
   otherwise_fragment += Constant(url);
@@ skipping 299 matching lines @@
       ASSERT(!klass.IsNull());
       const dart::Function& constructor = dart::Function::ZoneHandle(
           Z, klass.LookupConstructorAllowPrivate(
                  H.DartSymbol("FallThroughError._create")));
       ASSERT(!constructor.IsNull());
       const dart::String& url = H.DartString(
           parsed_function()->function().ToLibNamePrefixedQualifiedCString(),
           Heap::kOld);
 
       // Create instance of _FallThroughError
-      body_fragment += AllocateObject(klass, 0);
+      body_fragment += AllocateObject(TokenPosition::kNoSource, klass, 0);

[Vyacheslav Egorov (Google), 2017/06/16 11:09:18]

I guess this needs some informative position eventually. 

[jensj, 2017/06/16 11:39:07]

I'll give parser.cc an extra look to see if I can find which position the
source-based pipeline uses.

[jensj, 2017/06/16 11:55:33]

Actually, this gives us the excellent exception
```
'null': Switch case fall-through at line null.
```

So I'll create a new CL for fixing that anyways.

       LocalVariable* instance = MakeTemporary();
 
       // Call _FallThroughError._create constructor.
       body_fragment += LoadLocal(instance);
       body_fragment += PushArgument();  // this
 
       body_fragment += Constant(url);
       body_fragment += PushArgument();  // url
 
       body_fragment += NullConstant();
@@ skipping 898 matching lines @@
     metadata_values.SetAt(i, value);
   }
 
   return metadata_values.raw();
 }
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)