Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Issue 2944433002: Add tests for handling closures in LocalInitializers (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov
Modified:
3 years, 5 months ago
Reviewers:
sjindel
CC:
reviews_dartlang.org, karlklose
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for handling closures in LocalInitializers BUG=https://github.com/dart-lang/sdk/issues/29887 R=sjindel@google.com Committed: https://github.com/dart-lang/sdk/commit/b1e629f07855db95ec83ac183d4c29ae438d95e1

Patch Set 1 : Add tests to detect closure conversion issues in LocalInitializers #

Patch Set 2 : Add closures test suite to check issues with local initializers #

Patch Set 3 : Merge in latest changes in master (e451f16db0) #

Patch Set 4 : Change status for test local_initializers.dart to Crash #

Patch Set 5 : Merge in latest changes in master (e340ee517a) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -13 lines) Patch
A pkg/kernel/lib/transformations/argument_extraction_for_redirecting.dart View 1 chunk +66 lines, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/converter.dart View 1 2 3 chunks +43 lines, -6 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/rewriter.dart View 1 2 3 chunks +33 lines, -7 lines 0 comments Download
A pkg/kernel/test/closures_initializers/closures_initializers.status View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/kernel/test/closures_initializers/suite.dart View 1 1 chunk +172 lines, -0 lines 0 comments Download
A pkg/kernel/test/closures_initializers/testing.json View 1 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/closures_initializers/local_initializers.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/closures_initializers/local_initializers.dart.expect View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dmitry Stefantsov
I created this CL a while ago, when closure invalidation pass inserted a "throw" in ...
3 years, 5 months ago (2017-07-06 12:30:54 UTC) #4
sjindel
lgtm
3 years, 5 months ago (2017-07-06 14:36:48 UTC) #5
Dmitry Stefantsov
3 years, 5 months ago (2017-07-06 14:39:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
b1e629f07855db95ec83ac183d4c29ae438d95e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698