Issue 2944413002: optimize null safe ops by using DDC's let abstraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2944413002: optimize null safe ops by using DDC's let abstraction (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly

Modified:
3 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

optimize null safe ops by using DDC's let abstraction We were already using it for most other things (increment ops, op assign, ??, cascades, etc) R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/070f31a8999eb184f0b185988da8aff53048f7bd

Created: 3 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -57 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 chunk	+8 lines, -35 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/side_effect_analysis.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Total messages: 5 (2 generated)

vsm

lgtm I was trying to preserve the nullSafe readability for more complex expressions. But this ...

3 years, 6 months ago (2017-06-20 16:58:55 UTC) #3

Jennifer Messerly

3 years, 6 months ago (2017-06-20 17:31:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
070f31a8999eb184f0b185988da8aff53048f7bd (presubmit successful).