Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2944383002: translate fasta parser error to analyzer error (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

translate fasta parser error to analyzer error * translate fasta parser BuiltInIdentifierAsType error to analyzer error * remove unused error listener field R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/d0910ce078fb4e80446086eab90776d6d1450576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser_fasta.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 4 chunks +4 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +15 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 6 months ago (2017-06-20 15:07:44 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-20 15:43:22 UTC) #3
danrubel
3 years, 6 months ago (2017-06-20 17:18:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0910ce078fb4e80446086eab90776d6d1450576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698