Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: content/common/content_security_policy/csp_source_list.cc

Issue 2944373002: CSP: Remove wrong DCHECK in CSPSourceList (Closed)
Patch Set: Add test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/content_security_policy/csp_source_list_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/content_security_policy/csp_source_list.cc
diff --git a/content/common/content_security_policy/csp_source_list.cc b/content/common/content_security_policy/csp_source_list.cc
index d48b7c77b332d7d13c3d9904aa38364148196af7..31a5f4969d6638ee793c0f91ad2ca165f222be6a 100644
--- a/content/common/content_security_policy/csp_source_list.cc
+++ b/content/common/content_security_policy/csp_source_list.cc
@@ -27,10 +27,7 @@ CSPSourceList::CSPSourceList()
CSPSourceList::CSPSourceList(bool allow_self,
bool allow_star,
std::vector<CSPSource> sources)
- : allow_self(allow_self), allow_star(allow_star), sources(sources) {
- // When the '*' source is used, it must be the only one.
- DCHECK(!allow_star || (!allow_self && sources.empty()));
-}
+ : allow_self(allow_self), allow_star(allow_star), sources(sources) {}
CSPSourceList::CSPSourceList(const CSPSourceList&) = default;
CSPSourceList::~CSPSourceList() = default;
« no previous file with comments | « no previous file | content/common/content_security_policy/csp_source_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698