Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: chrome/browser/net/proxy_service_factory.cc

Issue 2944313003: Remove the dependence on BrowserThread::FILE for (Closed)
Patch Set: address mmenke's comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/proxy_service_factory.cc
diff --git a/chrome/browser/net/proxy_service_factory.cc b/chrome/browser/net/proxy_service_factory.cc
index dcb7c5c30e9e139b941efd82e51e6d42d84db7b7..f53dc2f428c62064e452fdc172347281c30d7a18 100644
--- a/chrome/browser/net/proxy_service_factory.cc
+++ b/chrome/browser/net/proxy_service_factory.cc
@@ -52,12 +52,8 @@ ProxyServiceFactory::CreateProxyConfigService(PrefProxyConfigTracker* tracker) {
// configuration in case nothing is configured through prefs (Note: prefs
// include command line and configuration policy).
- // TODO(port): the IO and FILE message loops are only used by Linux. Can
- // that code be moved to chrome/browser instead of being in net, so that it
- // can use BrowserThread instead of raw MessageLoop pointers? See bug 25354.
base_service = net::ProxyService::CreateSystemProxyConfigService(
- BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
- BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
+ BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));
#endif // !defined(OS_CHROMEOS)
return tracker->CreateTrackingProxyConfigService(std::move(base_service));
« no previous file with comments | « android_webview/browser/aw_browser_context.cc ('k') | chrome/service/net/service_url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698