Support for IPV6 for observatory in Dartium.

Support for IPV6 for observatory in Dartium.

R=rmacnak@google.com
BUG=62811100
Committed: https://github.com/dart-lang/sdk/commit/092cbd561de8c5184481af744f087d2079b50234

[rmacnak, 2017-06-20 21:24:06]

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
File runtime/bin/vmservice_dartium.cc (right):

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:28: static const char*
DEFAULT_VM_SERVICE_SERVER_IP_V6 = "localhost";
Do you mean ::1?

localhost could resolve to 127.0.0.1 or ::1 on an IPv6-capable system, but
presumably DART_IPV6_ONLY_FLAG should force ::1

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:32: static int IsIpv6Only() {
int -> bool

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:68: int ipv6 = IsIpv6Only();
int -> bool

[terry, 2017-06-20 21:39:02]

PTAL

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
File runtime/bin/vmservice_dartium.cc (right):

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:28: static const char*
DEFAULT_VM_SERVICE_SERVER_IP_V6 = "localhost";
On 2017/06/20 21:24:06, rmacnak wrote:
> Do you mean ::1?
> 
> localhost could resolve to 127.0.0.1 or ::1 on an IPv6-capable system, but
> presumably DART_IPV6_ONLY_FLAG should force ::1

Done.

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:32: static int IsIpv6Only() {
On 2017/06/20 21:24:06, rmacnak wrote:
> int -> bool

Done.

https://codereview.chromium.org/2944303003/diff/40001/runtime/bin/vmservice_d...
runtime/bin/vmservice_dartium.cc:68: int ipv6 = IsIpv6Only();
On 2017/06/20 21:24:05, rmacnak wrote:
> int -> bool

Done.

[rmacnak, 2017-06-20 21:41:43]

lgtm

[terry, 2017-06-21 02:32:10]

Description was changed from

==========
Support for IPV6 for observatory in Dartium.

R=rmacnak@google.com
BUG=62811100
==========

to

==========
Support for IPV6 for observatory in Dartium.

R=rmacnak@google.com
BUG=62811100

Committed:
https://github.com/dart-lang/sdk/commit/092cbd561de8c5184481af744f087d2079b50234
==========

[terry, 2017-06-21 02:32:12]

Committed patchset #4 (id:60001) manually as
092cbd561de8c5184481af744f087d2079b50234 (presubmit successful).