Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/browser/about_flags.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 13ea874df31999cf3fcec4a1a95c4639c6587a0e..736a02126ab306e039c383e07ae7a36e47ed071f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1989,10 +1989,11 @@ const FeatureEntry kFeatureEntries[] = {
{"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
- {"enable-add-to-shelf", flag_descriptions::kAddToShelfName,
- flag_descriptions::kAddToShelfDescription, kOsDesktop,
- ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf,
- switches::kDisableAddToShelf)},
+#if !defined(OS_ANDROID)
+ {"enable-app-banners", flag_descriptions::kAppBannersName,
+ flag_descriptions::kAppBannersDescription, kOsDesktop,
+ FEATURE_VALUE_TYPE(features::kAppBanners)},
+#endif // !OS_ANDROID
{"bypass-app-banner-engagement-checks",
flag_descriptions::kBypassAppBannerEngagementChecksName,
flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll,
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698