Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_features.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 11 matching lines...) Expand all
22 #if defined(OS_MACOSX) 22 #if defined(OS_MACOSX)
23 // Enables Javascript execution via AppleScript. 23 // Enables Javascript execution via AppleScript.
24 const base::Feature kAppleScriptExecuteJavaScript{ 24 const base::Feature kAppleScriptExecuteJavaScript{
25 "AppleScriptExecuteJavaScript", base::FEATURE_ENABLED_BY_DEFAULT}; 25 "AppleScriptExecuteJavaScript", base::FEATURE_ENABLED_BY_DEFAULT};
26 26
27 // Use the Toolkit-Views Task Manager window. 27 // Use the Toolkit-Views Task Manager window.
28 const base::Feature kViewsTaskManager{"ViewsTaskManager", 28 const base::Feature kViewsTaskManager{"ViewsTaskManager",
29 base::FEATURE_DISABLED_BY_DEFAULT}; 29 base::FEATURE_DISABLED_BY_DEFAULT};
30 #endif // defined(OS_MACOSX) 30 #endif // defined(OS_MACOSX)
31 31
32 #if !defined(OS_ANDROID)
33 const base::Feature kAppBanners {
34 "AppBanners",
35 #if defined(OS_CHROMEOS)
36 base::FEATURE_ENABLED_BY_DEFAULT,
37 #else
38 base::FEATURE_DISABLED_BY_DEFAULT,
39 #endif // defined(OS_CHROMEOS)
40 };
41 #endif // !defined(OS_ANDROID)
42
32 #if defined(OS_CHROMEOS) 43 #if defined(OS_CHROMEOS)
33 // Whether to handle low memory kill of ARC apps by Chrome. 44 // Whether to handle low memory kill of ARC apps by Chrome.
34 const base::Feature kArcMemoryManagement{ 45 const base::Feature kArcMemoryManagement{
35 "ArcMemoryManagement", base::FEATURE_ENABLED_BY_DEFAULT}; 46 "ArcMemoryManagement", base::FEATURE_ENABLED_BY_DEFAULT};
36 #endif // defined(OS_CHROMEOS) 47 #endif // defined(OS_CHROMEOS)
37 48
38 // If enabled, the list of content suggestions on the New Tab page will contain 49 // If enabled, the list of content suggestions on the New Tab page will contain
39 // assets (e.g. books, pictures, audio) that the user downloaded for later use. 50 // assets (e.g. books, pictures, audio) that the user downloaded for later use.
40 const base::Feature kAssetDownloadSuggestionsFeature{ 51 const base::Feature kAssetDownloadSuggestionsFeature{
41 "NTPAssetDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 52 "NTPAssetDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 return base::FeatureList::IsEnabled(features::kPrefService) || 405 return base::FeatureList::IsEnabled(features::kPrefService) ||
395 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 406 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
396 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 407 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
397 switches::kMusConfig) == switches::kMash; 408 switches::kMusConfig) == switches::kMash;
398 #else 409 #else
399 false; 410 false;
400 #endif 411 #endif
401 } 412 }
402 413
403 } // namespace features 414 } // namespace features
OLDNEW
« no previous file with comments | « chrome/common/chrome_features.h ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698