Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1971 matching lines...) Expand 10 before | Expand all | Expand 10 after
1982 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName, 1982 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
1983 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid, 1983 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
1984 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)}, 1984 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
1985 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName, 1985 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
1986 flag_descriptions::kEnableClientLoFiDescription, kOsAndroid, 1986 flag_descriptions::kEnableClientLoFiDescription, kOsAndroid,
1987 FEATURE_VALUE_TYPE(previews::features::kClientLoFi)}, 1987 FEATURE_VALUE_TYPE(previews::features::kClientLoFi)},
1988 #endif // OS_ANDROID 1988 #endif // OS_ANDROID
1989 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName, 1989 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
1990 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll, 1990 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
1991 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1991 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1992 {"enable-add-to-shelf", flag_descriptions::kAddToShelfName, 1992 #if !defined(OS_ANDROID)
1993 flag_descriptions::kAddToShelfDescription, kOsDesktop, 1993 {"enable-app-banners", flag_descriptions::kAppBannersName,
1994 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1994 flag_descriptions::kAppBannersDescription, kOsDesktop,
1995 switches::kDisableAddToShelf)}, 1995 FEATURE_VALUE_TYPE(features::kAppBanners)},
1996 #endif // !OS_ANDROID
1996 {"bypass-app-banner-engagement-checks", 1997 {"bypass-app-banner-engagement-checks",
1997 flag_descriptions::kBypassAppBannerEngagementChecksName, 1998 flag_descriptions::kBypassAppBannerEngagementChecksName,
1998 flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll, 1999 flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll,
1999 SINGLE_VALUE_TYPE(switches::kBypassAppBannerEngagementChecks)}, 2000 SINGLE_VALUE_TYPE(switches::kBypassAppBannerEngagementChecks)},
2000 {"use-sync-sandbox", flag_descriptions::kSyncSandboxName, 2001 {"use-sync-sandbox", flag_descriptions::kSyncSandboxName,
2001 flag_descriptions::kSyncSandboxDescription, kOsAll, 2002 flag_descriptions::kSyncSandboxDescription, kOsAll,
2002 SINGLE_VALUE_TYPE_AND_VALUE( 2003 SINGLE_VALUE_TYPE_AND_VALUE(
2003 switches::kSyncServiceURL, 2004 switches::kSyncServiceURL,
2004 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha")}, 2005 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha")},
2005 #if !defined(OS_ANDROID) 2006 #if !defined(OS_ANDROID)
(...skipping 1315 matching lines...) Expand 10 before | Expand all | Expand 10 after
3321 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3322 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3322 3323
3323 const FeatureEntry* GetFeatureEntries(size_t* count) { 3324 const FeatureEntry* GetFeatureEntries(size_t* count) {
3324 *count = arraysize(kFeatureEntries); 3325 *count = arraysize(kFeatureEntries);
3325 return kFeatureEntries; 3326 return kFeatureEntries;
3326 } 3327 }
3327 3328
3328 } // namespace testing 3329 } // namespace testing
3329 3330
3330 } // namespace about_flags 3331 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698