Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/flag_descriptions.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Double Doh! Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/flag_descriptions.h" 5 #include "chrome/browser/flag_descriptions.h"
6 6
7 namespace flag_descriptions { 7 namespace flag_descriptions {
8 8
9 const char kBrowserSideNavigationName[] = "Enable browser side navigation"; 9 const char kBrowserSideNavigationName[] = "Enable browser side navigation";
10 10
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 257
258 const char kSecondaryUiMdDescription[] = 258 const char kSecondaryUiMdDescription[] =
259 "Extends the --top-chrome-md setting to secondary UI (bubbles, dialogs, " 259 "Extends the --top-chrome-md setting to secondary UI (bubbles, dialogs, "
260 "etc.). On Mac, this enables MacViews, which uses toolkit-views for " 260 "etc.). On Mac, this enables MacViews, which uses toolkit-views for "
261 "native browser dialogs."; 261 "native browser dialogs.";
262 262
263 const char kScrollPredictionDescription[] = 263 const char kScrollPredictionDescription[] =
264 "Predicts the finger's future position during scrolls allowing time to " 264 "Predicts the finger's future position during scrolls allowing time to "
265 "render the frame before the finger is there."; 265 "render the frame before the finger is there.";
266 266
267 const char kAddToShelfName[] = "Add to shelf"; 267 const char kAppBannersName[] = "App Banners";
268 268
269 const char kAddToShelfDescription[] = 269 const char kAppBannersDescription[] =
270 "Enable the display of add to shelf banners, which prompt a user to add " 270 "Enable the display of Progressive Web App banners, which prompt a user to "
271 "a web app to their shelf, or other platform-specific equivalent."; 271 "add a web app to their shelf, or other platform-specific equivalent.";
272 272
273 const char kBypassAppBannerEngagementChecksName[] = 273 const char kBypassAppBannerEngagementChecksName[] =
274 "Bypass user engagement checks"; 274 "Bypass user engagement checks";
275 275
276 const char kBypassAppBannerEngagementChecksDescription[] = 276 const char kBypassAppBannerEngagementChecksDescription[] =
277 "Bypasses user engagement checks for displaying app banners, such as " 277 "Bypasses user engagement checks for displaying app banners, such as "
278 "requiring that users have visited the site before and that the banner " 278 "requiring that users have visited the site before and that the banner "
279 "hasn't been shown recently. This allows developers to test that other " 279 "hasn't been shown recently. This allows developers to test that other "
280 "eligibility requirements for showing app banners, such as having a " 280 "eligibility requirements for showing app banners, such as having a "
281 "manifest, are met."; 281 "manifest, are met.";
(...skipping 2951 matching lines...) Expand 10 before | Expand all | Expand 10 after
3233 "in non-sticky mode (do not change work area in non-sticky mode)."; 3233 "in non-sticky mode (do not change work area in non-sticky mode).";
3234 3234
3235 const char kUiDevToolsName[] = "Enable native UI inspection"; 3235 const char kUiDevToolsName[] = "Enable native UI inspection";
3236 const char kUiDevToolsDescription[] = 3236 const char kUiDevToolsDescription[] =
3237 "Enables inspection of native UI elements. For local inspection use " 3237 "Enables inspection of native UI elements. For local inspection use "
3238 "chrome://inspect#other"; 3238 "chrome://inspect#other";
3239 3239
3240 #endif // defined(OS_CHROMEOS) 3240 #endif // defined(OS_CHROMEOS)
3241 3241
3242 } // namespace flag_descriptions 3242 } // namespace flag_descriptions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698