Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2944283002: Replace --add-to-shelf flag with kAppBanners feature. (Closed)
Patch Set: Double Doh! Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1959 matching lines...) Expand 10 before | Expand all | Expand 10 after
1970 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName, 1970 {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
1971 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid, 1971 flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
1972 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)}, 1972 FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
1973 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName, 1973 {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
1974 flag_descriptions::kEnableClientLoFiDescription, kOsAndroid, 1974 flag_descriptions::kEnableClientLoFiDescription, kOsAndroid,
1975 FEATURE_VALUE_TYPE(previews::features::kClientLoFi)}, 1975 FEATURE_VALUE_TYPE(previews::features::kClientLoFi)},
1976 #endif // OS_ANDROID 1976 #endif // OS_ANDROID
1977 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName, 1977 {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
1978 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll, 1978 flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
1979 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1979 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1980 {"enable-add-to-shelf", flag_descriptions::kAddToShelfName, 1980 #if !defined(OS_ANDROID)
1981 flag_descriptions::kAddToShelfDescription, kOsDesktop, 1981 {"enable-app-banners", flag_descriptions::kAppBannersName,
1982 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1982 flag_descriptions::kAppBannersDescription, kOsDesktop,
1983 switches::kDisableAddToShelf)}, 1983 FEATURE_VALUE_TYPE(features::kAppBanners)},
1984 #endif // !OS_ANDROID
1984 {"bypass-app-banner-engagement-checks", 1985 {"bypass-app-banner-engagement-checks",
1985 flag_descriptions::kBypassAppBannerEngagementChecksName, 1986 flag_descriptions::kBypassAppBannerEngagementChecksName,
1986 flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll, 1987 flag_descriptions::kBypassAppBannerEngagementChecksDescription, kOsAll,
1987 SINGLE_VALUE_TYPE(switches::kBypassAppBannerEngagementChecks)}, 1988 SINGLE_VALUE_TYPE(switches::kBypassAppBannerEngagementChecks)},
1988 {"use-sync-sandbox", flag_descriptions::kSyncSandboxName, 1989 {"use-sync-sandbox", flag_descriptions::kSyncSandboxName,
1989 flag_descriptions::kSyncSandboxDescription, kOsAll, 1990 flag_descriptions::kSyncSandboxDescription, kOsAll,
1990 SINGLE_VALUE_TYPE_AND_VALUE( 1991 SINGLE_VALUE_TYPE_AND_VALUE(
1991 switches::kSyncServiceURL, 1992 switches::kSyncServiceURL,
1992 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha")}, 1993 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha")},
1993 #if !defined(OS_ANDROID) 1994 #if !defined(OS_ANDROID)
(...skipping 1315 matching lines...) Expand 10 before | Expand all | Expand 10 after
3309 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3310 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3310 3311
3311 const FeatureEntry* GetFeatureEntries(size_t* count) { 3312 const FeatureEntry* GetFeatureEntries(size_t* count) {
3312 *count = arraysize(kFeatureEntries); 3313 *count = arraysize(kFeatureEntries);
3313 return kFeatureEntries; 3314 return kFeatureEntries;
3314 } 3315 }
3315 3316
3316 } // namespace testing 3317 } // namespace testing
3317 3318
3318 } // namespace about_flags 3319 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698