Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 294423004: Add more BUILD.gn files to build these targets with GN. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews, awong, brettw, Dirk Pranke
Visibility:
Public.

Description

Add more BUILD.gn files to build these targets with GN. This patch converts the following gyp targets to GN: - favicon_base - query_parser - metro_viewer_messages -> metro_viewer - native_theme BUG=None TEST=None R=scottmg@chromium.org TBR=ben@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272739

Patch Set 1 : #

Total comments: 2

Patch Set 2 : add instead #

Total comments: 2

Patch Set 3 : non aura build #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -1 line) Patch
M BUILD.gn View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
A components/favicon_base/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A components/query_parser/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/metro_viewer/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A ui/native_theme/BUILD.gn View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 7 months ago (2014-05-24 01:50:18 UTC) #1
scottmg
lgtm https://codereview.chromium.org/294423004/diff/20001/ui/native_theme/BUILD.gn File ui/native_theme/BUILD.gn (right): https://codereview.chromium.org/294423004/diff/20001/ui/native_theme/BUILD.gn#newcode47 ui/native_theme/BUILD.gn:47: if (!use_aura || !is_win) { this seems a ...
6 years, 7 months ago (2014-05-24 01:57:06 UTC) #2
tfarina
https://codereview.chromium.org/294423004/diff/20001/ui/native_theme/BUILD.gn File ui/native_theme/BUILD.gn (right): https://codereview.chromium.org/294423004/diff/20001/ui/native_theme/BUILD.gn#newcode47 ui/native_theme/BUILD.gn:47: if (!use_aura || !is_win) { On 2014/05/24 01:57:06, scottmg ...
6 years, 7 months ago (2014-05-24 02:10:31 UTC) #3
brettw
https://codereview.chromium.org/294423004/diff/40001/ui/native_theme/BUILD.gn File ui/native_theme/BUILD.gn (right): https://codereview.chromium.org/294423004/diff/40001/ui/native_theme/BUILD.gn#newcode45 ui/native_theme/BUILD.gn:45: if (use_aura && is_win) { Heh, I did this ...
6 years, 7 months ago (2014-05-24 04:49:30 UTC) #4
tfarina
https://codereview.chromium.org/294423004/diff/40001/ui/native_theme/BUILD.gn File ui/native_theme/BUILD.gn (right): https://codereview.chromium.org/294423004/diff/40001/ui/native_theme/BUILD.gn#newcode45 ui/native_theme/BUILD.gn:45: if (use_aura && is_win) { On 2014/05/24 04:49:30, brettw ...
6 years, 7 months ago (2014-05-24 05:40:36 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-24 07:22:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/294423004/70001
6 years, 7 months ago (2014-05-24 07:22:47 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 13:21:51 UTC) #8
Message was sent while issue was closed.
Change committed as 272739

Powered by Google App Engine
This is Rietveld 408576698