Issue 2944223002: Revert "Updated parser to produce error when trying to reinitialize final variables in class constr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2944223002: Revert "Updated parser to produce error when trying to reinitialize final variables in class constr… (Closed)

Created:
3 years, 6 months ago by bkonyi

Modified:
3 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658." This reverts commit b5cff3f68f728af87f88f2f76eecfb224e303278. TBR=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/a4a227e375360ecd2204b5bdf8b3d1237eebe1a9

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -81 lines)			Patch
M	runtime/vm/parser.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+0 lines, -49 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-kernel.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/const_error_multiply_initialized_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tests/language/final_attempt_reinitialization_test.dart	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

bkonyi

Committed patchset #1 (id:1) manually as a4a227e375360ecd2204b5bdf8b3d1237eebe1a9 (presubmit successful).

3 years, 6 months ago (2017-06-20 00:23:11 UTC) #2

Message was sent while issue was closed.

lgtm