Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/patch_sdk.py

Issue 2944103003: Introduce dart_host_toolchain arg, remove '--checked' option from patch_sdk.py (Closed)
Patch Set: Introduce dart_host_toolchain arg Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/generate_patch_sdk.gni » ('j') | utils/generate_patch_sdk.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/patch_sdk.py
diff --git a/tools/patch_sdk.py b/tools/patch_sdk.py
index 212514a8190c91144052e5513e2f7be5560185df..25e553ed8a489a576a10c6b43457f945ebf864d3 100755
--- a/tools/patch_sdk.py
+++ b/tools/patch_sdk.py
@@ -48,8 +48,7 @@ def main():
print >> sys.stderr, 'ERROR: cannot locate dart executable'
return -1
dart_file = os.path.join(os.path.dirname(__file__), 'patch_sdk.dart')
- subprocess.check_call(
- [options.dart_executable, '--checked', dart_file] + args)
+ subprocess.check_call([options.dart_executable, dart_file] + args)
siva 2017/06/22 01:15:14 Why do we drop the '--checked' option?
return 0
if __name__ == '__main__':
« no previous file with comments | « no previous file | utils/generate_patch_sdk.gni » ('j') | utils/generate_patch_sdk.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698