tools/patch_sdk.py - Issue 2944103003: Introduce dart_host_toolchain arg, remove '--checked' option from patch_sdk.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/patch_sdk.py

Issue 2944103003: Introduce dart_host_toolchain arg, remove '--checked' option from patch_sdk.py (Closed)

Patch Set: Update comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/patch_sdk.py

diff --git a/tools/patch_sdk.py b/tools/patch_sdk.py

index 212514a8190c91144052e5513e2f7be5560185df..a939a9641606ea2253054a7dbc0e97a7a914f52d 100755

--- a/tools/patch_sdk.py

+++ b/tools/patch_sdk.py

@@ -48,8 +48,10 @@ def main():

print >> sys.stderr, 'ERROR: cannot locate dart executable'

return -1

dart_file = os.path.join(os.path.dirname(__file__), 'patch_sdk.dart')

+ # '--checked' is not recognized by Dart executable built for Flutter Release

rmacnak 2017/06/20 20:40:50 Product mode does not allow checked mode. This sho

subprocess.check_call(

- [options.dart_executable, '--checked', dart_file] + args)

+ [options.dart_executable, '--ignore_unrecognized_flags',

+ '--checked', dart_file] + args)

return 0

if __name__ == '__main__':

« no previous file with comments | « no previous file | utils/generate_patch_sdk.gni » ('j') | no next file with comments »