Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: utils/generate_patch_sdk.gni

Issue 2944103003: Introduce dart_host_toolchain arg, remove '--checked' option from patch_sdk.py (Closed)
Patch Set: Add comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/patch_sdk.py ('k') | utils/kernel-service/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 import("../build/prebuilt_dart_sdk.gni") 5 import("../build/prebuilt_dart_sdk.gni")
6 import("../build/dart_host_toolchain.gni")
6 7
7 _dart_root = get_path_info("..", "abspath") 8 _dart_root = get_path_info("..", "abspath")
8 9
9 # Template to generate a patched_sdk folder. This invokes the tools/patch_sdk.py 10 # Template to generate a patched_sdk folder. This invokes the tools/patch_sdk.py
10 # script and sets up the right dependencies. 11 # script and sets up the right dependencies.
11 # 12 #
12 # This template expects four arguments: 13 # This template expects four arguments:
13 # - mode: vm or dart2js (whether to build an sdk for the vm or for dart2js) 14 # - mode: vm or dart2js (whether to build an sdk for the vm or for dart2js)
14 # - input_patches_dir: directory containing the input library files. 15 # - input_patches_dir: directory containing the input library files.
15 # - patched_sdk_dir: the output location 16 # - patched_sdk_dir: the output location
16 # - deps: extra dependencies that must be built ahead of time. 17 # - deps: extra dependencies that must be built ahead of time.
17 template("generate_patched_sdk") { 18 template("generate_patched_sdk") {
18 assert(defined(invoker.input_patches_dir), 19 assert(defined(invoker.input_patches_dir),
19 "Need input_patches_dir in $target_name") 20 "Need input_patches_dir in $target_name")
20 assert(defined(invoker.patched_sdk_dir), 21 assert(defined(invoker.patched_sdk_dir),
21 "Need patched_sdk_dir in $target_name") 22 "Need patched_sdk_dir in $target_name")
22 assert(defined(invoker.mode), "Need mode in $target_name") 23 assert(defined(invoker.mode), "Need mode in $target_name")
23 action(target_name) { 24 action(target_name) {
24 if (defined(invoker.deps)) { 25 if (defined(invoker.deps)) {
25 deps = invoker.deps 26 deps = invoker.deps
26 } else { 27 } else {
27 deps = [] 28 deps = []
28 } 29 }
29 30
30 if (!prebuilt_dart_exe_works) { 31 if (!prebuilt_dart_exe_works) {
31 deps += [ "$_dart_root/runtime/bin:dart_bootstrap($host_toolchain)" ] 32 deps += [ "$_dart_root/runtime/bin:dart_bootstrap_host_arch($dart_host_too lchain)" ]
32 } 33 }
33 34
34 script = "$_dart_root/tools/patch_sdk.py" 35 script = "$_dart_root/tools/patch_sdk.py"
35 36
36 # We list the `patch_sdk.dart` tool here because the [script] (which is 37 # We list the `patch_sdk.dart` tool here because the [script] (which is
37 # implicitly an input) will call it. 38 # implicitly an input) will call it.
38 inputs = [ 39 inputs = [
39 "$_dart_root/tools/patch_sdk.dart", 40 "$_dart_root/tools/patch_sdk.dart",
40 ] 41 ]
41 42
42 depfile = "$root_out_dir/${target_name}.d" 43 depfile = "$root_out_dir/${target_name}.d"
43 44
44 outputs = [ 45 outputs = [
45 # Instead of listing all outputs we list a single well-known one. 46 # Instead of listing all outputs we list a single well-known one.
46 "$root_out_dir/${invoker.patched_sdk_dir}/platform.dill", 47 "$root_out_dir/${invoker.patched_sdk_dir}/platform.dill",
47 ] 48 ]
48 49
49 args = [ "--quiet" ] 50 args = [ "--quiet" ]
50 if (!prebuilt_dart_exe_works) { 51 if (!prebuilt_dart_exe_works) {
51 dart_out_dir = get_label_info( 52 dart_out_dir = get_label_info(
52 "$_dart_root/runtime/bin:dart_bootstrap($host_toolchain)", 53 "$_dart_root/runtime/bin:dart_bootstrap_host_arch($dart_host_toolc hain)",
53 "root_out_dir") 54 "root_out_dir")
54 dart_bootstrap = 55 dart_bootstrap =
55 rebase_path("$dart_out_dir/dart_bootstrap$executable_suffix") 56 rebase_path("$dart_out_dir/dart_bootstrap$executable_suffix")
56 args += [ 57 args += [
57 "--dart-executable", 58 "--dart-executable",
58 dart_bootstrap, 59 dart_bootstrap,
59 ] 60 ]
60 } 61 }
61 args += [ 62 args += [
62 invoker.mode, 63 invoker.mode,
63 rebase_path("$_dart_root/sdk"), 64 rebase_path("$_dart_root/sdk"),
64 rebase_path(invoker.input_patches_dir), 65 rebase_path(invoker.input_patches_dir),
65 rebase_path("$root_out_dir/${invoker.patched_sdk_dir}", root_build_dir), 66 rebase_path("$root_out_dir/${invoker.patched_sdk_dir}", root_build_dir),
66 rebase_path("$_dart_root/.packages"), 67 rebase_path("$_dart_root/.packages"),
67 ] 68 ]
68 } 69 }
69 } 70 }
OLDNEW
« no previous file with comments | « tools/patch_sdk.py ('k') | utils/kernel-service/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698