Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart

Issue 2944083002: Handle unresolved constructor (issue 29925) (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart
diff --git a/pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart b/pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart
index a00a24b43f55c10cd3e72243e4be2a968adce4c7..43128a53d528031e658a68fe7ed59b55a63dd24e 100644
--- a/pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart
+++ b/pkg/analyzer_plugin/lib/src/utilities/completion/optype.dart
@@ -738,17 +738,19 @@ class _OpTypeAstVisitor extends GeneralizingAstVisitor {
if (grandparent is ConstructorReferenceNode) {
ConstructorElement element =
(grandparent as ConstructorReferenceNode).staticElement;
- List<ParameterElement> parameters = element.parameters;
- ParameterElement parameterElement = parameters.firstWhere((e) {
- if (e is DefaultFieldFormalParameterElementImpl) {
- return e.field.name == node.name.label.name;
+ if (element != null) {
+ List<ParameterElement> parameters = element.parameters;
+ ParameterElement parameterElement = parameters.firstWhere((e) {
+ if (e is DefaultFieldFormalParameterElementImpl) {
+ return e.field.name == node.name.label.name;
+ }
+ return e.parameterKind == ParameterKind.NAMED &&
+ e.name == node.name.label.name;
+ }, orElse: () => null);
+ // Suggest tear-offs.
+ if (parameterElement?.type is FunctionType) {
+ optype.includeVoidReturnSuggestions = true;
}
- return e.parameterKind == ParameterKind.NAMED &&
- e.name == node.name.label.name;
- }, orElse: () => null);
- // Suggest tear-offs.
- if (parameterElement?.type is FunctionType) {
- optype.includeVoidReturnSuggestions = true;
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698