Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 2944073003: Reapply "Minor adjustment to usage of the ClosureClassRepresentation interface." (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Minor adjustment to usage of the ClosureClassRepresentation interface." This reverts commit 0ee0717cc3d919bb454c5627bf35987bf11e90ad. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d9c6ae343802a70ee4e3d957ea5cfcdc68759d5f

Patch Set 1 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +4 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
Let's try this again. I know this one is slightly more verbose than the original, ...
3 years, 6 months ago (2017-06-20 00:23:19 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2944073003/diff/20001/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart File pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart (right): https://codereview.chromium.org/2944073003/diff/20001/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart#newcode131 pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart:131: if (closureData.isClosure && closureData.thisLocal != null) { is ...
3 years, 6 months ago (2017-06-20 00:30:22 UTC) #4
Emily Fortuna
3 years, 6 months ago (2017-06-20 00:39:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
d9c6ae343802a70ee4e3d957ea5cfcdc68759d5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698