Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2944073002: Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a… (Closed)

Created:
3 years, 6 months ago by bkonyi
Modified:
3 years, 6 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a compilation error when trying to reinitialize a final field: https://github.com/dart-lang/co19/issues/114. BUG= Committed: https://github.com/dart-lang/sdk/commit/2cdfc0cdab6428fa12b2487c19a97eab5e1156b0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated co19-runtime.status to expect CompileTimeError #

Total comments: 2

Patch Set 3 : Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a… #

Patch Set 4 : Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a… #

Patch Set 5 : Fixed a typo in language_analyzer2.status #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/co19/co19-runtime.status View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M tests/language/language_analyzer2.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bkonyi
3 years, 6 months ago (2017-06-19 19:32:39 UTC) #2
zra
https://codereview.chromium.org/2944073002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/2944073002/diff/1/tests/co19/co19-co19.status#newcode20 tests/co19/co19-co19.status:20: Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02: Skip # co19 issue 114 Please don't skip. ...
3 years, 6 months ago (2017-06-19 19:35:46 UTC) #3
bkonyi
https://codereview.chromium.org/2944073002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/2944073002/diff/1/tests/co19/co19-co19.status#newcode20 tests/co19/co19-co19.status:20: Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02: Skip # co19 issue 114 On 2017/06/19 19:35:46, ...
3 years, 6 months ago (2017-06-19 19:43:58 UTC) #4
zra
https://codereview.chromium.org/2944073002/diff/20001/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/2944073002/diff/20001/tests/co19/co19-co19.status#newcode20 tests/co19/co19-co19.status:20: Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02: Skip # co19 issue 114 Should this be ...
3 years, 6 months ago (2017-06-19 19:46:50 UTC) #5
bkonyi
https://codereview.chromium.org/2944073002/diff/20001/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/2944073002/diff/20001/tests/co19/co19-co19.status#newcode20 tests/co19/co19-co19.status:20: Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02: Skip # co19 issue 114 On 2017/06/19 19:46:50, ...
3 years, 6 months ago (2017-06-19 19:55:30 UTC) #6
bkonyi
Committed patchset #5 (id:80001) manually as 2cdfc0cdab6428fa12b2487c19a97eab5e1156b0 (presubmit successful).
3 years, 6 months ago (2017-06-19 20:14:11 UTC) #8
siva
3 years, 6 months ago (2017-06-19 21:20:25 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2944073002/diff/80001/tests/co19/co19-runtime...
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/2944073002/diff/80001/tests/co19/co19-runtime...
tests/co19/co19-runtime.status:12:
Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02:
CompileTimeError
Shouldn't the test be morphed to use the @compile-error meta data, similar to
how things are handled in
tests/co19/src/Language/Classes/Constructors/Generative_Constructors/syntax_t05.dart
or other similar tests which expect a compile time error?

Powered by Google App Engine
This is Rietveld 408576698