Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: net/log/net_log_event_type_list.h

Issue 2944043002: Add NetLog events for HttpServerPropertiesManager (Closed)
Patch Set: fix ios Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_event_type_list.h
diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h
index 39a68bcb87568f580ad37cfcc6e30ef52a15c5e2..75e42ee15b308bf630bb09f15f05651c22e58697 100644
--- a/net/log/net_log_event_type_list.h
+++ b/net/log/net_log_event_type_list.h
@@ -3180,3 +3180,19 @@ EVENT_TYPE(RESOURCE_SCHEDULER_REQUEST_STARTED)
// type>,
// }
EVENT_TYPE(NETWORK_QUALITY_CHANGED)
+
+// -----------------------------------------------------------------------------
+// Http Server Properties Manager related events
+// -----------------------------------------------------------------------------
+
+// This event is emitted when HttpServerPropertiesManager initialization starts
+// and finishes.
+EVENT_TYPE(HTTP_SERVER_PROPERTIES_INITIALIZATION)
Zhongyi Shi 2017/06/19 19:50:24 nit: since these are all manager specific, could y
xunjieli 2017/06/19 20:09:32 Do you feel strongly about adding a MANAGER_ suffi
Zhongyi Shi 2017/06/20 20:00:53 Acknowledged. Okay, sounds like you have considere
+
+// This event is emitted when HttpServerPropertiesManager is updating in-memory
+// version of HttpServerProperties from the serialized version from perfs/disk.
+EVENT_TYPE(HTTP_SERVER_PROPERTIES_UPDATE_CACHE)
+
+// This event is emitted when HttpServerPropertiesManager is persisting
+// in-memory version of HttpServerProperties to prefs/disk.
+EVENT_TYPE(HTTP_SERVER_PROPERTIES_UPDATE_PREFS)

Powered by Google App Engine
This is Rietveld 408576698