Issue 2944017: Putting the findbar into a child window.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2944017: Putting the findbar into a child window. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by rohitrao (OOO until 6-22)

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Putting the findbar into a child window. Problems: - getting theme providers - drawing correctly based on main status - restoring focus (FocusTracker vs window) - moving child window when going fullscreen - not affecting window main status

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -5 lines)			Patch
M	chrome/browser/cocoa/background_gradient_view.mm	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.mm	View		2 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/find_bar_cocoa_controller.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/find_bar_cocoa_controller.mm	View	1	6 chunks	+66 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/find_bar_view.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Trybot results: