Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2944017: Putting the findbar into a child window. (Closed)

Created:
10 years, 5 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Putting the findbar into a child window. Problems: - getting theme providers - drawing correctly based on main status - restoring focus (FocusTracker vs window) - moving child window when going fullscreen - not affecting window main status

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -5 lines) Patch
M chrome/browser/cocoa/background_gradient_view.mm View 1 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 2 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/find_bar_cocoa_controller.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/find_bar_cocoa_controller.mm View 1 6 chunks +66 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/find_bar_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698