third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: .. Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/MediaDownloadInProductHelpManager.cpp ('k') | third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

index dfc7f4b377057c9c82f19dc11189d7e2d6e2d2a3..d43d1e08d6bfbfc26e37f216ee72d01ae267ec8f 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h

@@ -5,6 +5,7 @@

#ifndef MediaControlDownloadButtonElement_h

#define MediaControlDownloadButtonElement_h

+#include "modules/ModulesExport.h"

#include "modules/media_controls/elements/MediaControlInputElement.h"

namespace blink {

@@ -12,7 +13,7 @@ namespace blink {

class Event;

class MediaControlsImpl;

-class MediaControlDownloadButtonElement final

+class MODULES_EXPORT MediaControlDownloadButtonElement final

: public MediaControlInputElement {

public:

explicit MediaControlDownloadButtonElement(MediaControlsImpl&);

@@ -30,6 +31,7 @@ class MediaControlDownloadButtonElement final

protected:

const char* GetNameForHistograms() const final;

+ void UpdateShownState() final;

private:

// This is used for UMA histogram (Media.Controls.Download). New values should