third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: move IPH to MediaDownloadInProductManager Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp ('K') | « third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp ('k') | third_party/WebKit/Source/platform/mojo/Geometry.typemap » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h

index abfe535ac1642fd44e85b702206620b88a28de56..61ea2126dd0626f16cfec3d5c7da6f9f4c8f929c 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h

@@ -47,7 +47,7 @@ class MODULES_EXPORT MediaControlInputElement : public HTMLInputElement,

void DefaultEventHandler(Event*) override;

// Implements MediaControlElementBase.

- void UpdateShownState() final;

+ void UpdateShownState();

mlamouri (slow - plz ping) 2017/08/16 13:09:30 Maybe swap `final` with `override` instead of noth

Khushal 2017/08/16 19:01:23 Done.

// Updates the value of the Text string shown in the overflow menu.

void UpdateOverflowString();