third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: mounir's comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp ('K') | « third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp ('k') | third_party/WebKit/Source/platform/mojo/Geometry.typemap » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h

index 08c216a7165a663bb3f62b314dbc7598eb3f1220..036d09c4001ec8a50d632df6c0e31a6a4f05387f 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h

@@ -6,6 +6,7 @@

#define MediaControlElementBase_h

#include "core/dom/Element.h"

+#include "modules/ModulesExport.h"

#include "modules/media_controls/elements/MediaControlElementType.h"

#include "platform/heap/GarbageCollected.h"

#include "platform/heap/Visitor.h"

@@ -21,7 +22,7 @@ class MediaControlsImpl;

// MediaControlElementBase is the base class for all the media control elements.

// It is sub-classed by MediaControlInputElement and MediaControlDivElement

// which are then used by the final implementations.

-class MediaControlElementBase : public GarbageCollectedMixin {

+class MODULES_EXPORT MediaControlElementBase : public GarbageCollectedMixin {

mlamouri (slow - plz ping) 2017/07/25 17:29:08 Why is this required?

public:

// These hold the state about whether this control should be shown if

// space permits. These will also show / hide as needed.