Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: not on pause. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index c8bba03406999ebcf2a926da86f0cb5d7b5ef120..c27f3160c4ce9257a7b46c758f23545d217db108 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -120,6 +120,9 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void EndScrubbing();
void UpdateCurrentTimeDisplay();
+ bool IsVisible() const;
+ void HideControlsIfNecessary();
mlamouri (slow - plz ping) 2017/07/13 21:14:27 Having the buttons being able to hide the control
Khushal 2017/07/17 17:52:20 The controls will still check the internal state a
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -157,7 +160,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void MakeOpaque();
void MakeTransparent();
- bool IsVisible() const;
void UpdatePlayState();

Powered by Google App Engine
This is Rietveld 408576698