third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: move to button Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/media_in_product_help_manager.h ('K') | « third_party/WebKit/Source/modules/media_controls/DEPS ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

index c8bba03406999ebcf2a926da86f0cb5d7b5ef120..c27f3160c4ce9257a7b46c758f23545d217db108 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

@@ -120,6 +120,9 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,

void EndScrubbing();

void UpdateCurrentTimeDisplay();

+ bool IsVisible() const;

+ void HideControlsIfNecessary();

DECLARE_VIRTUAL_TRACE();

private:

@@ -157,7 +160,6 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,

void MakeOpaque();

void MakeTransparent();

- bool IsVisible() const;

void UpdatePlayState();