third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp - Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)

Patch Set: tests Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp ('K') | « third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp ('k') | third_party/WebKit/Source/platform/mojo/Geometry.typemap » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

index 2007c5d81496f008d9a3228e482bb144f32c404f..0dc3080397913380145c904d25edbe6f0bf4029f 100644

--- a/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

@@ -91,11 +91,14 @@ void MediaControlDownloadButtonElement::SetIsWanted(bool wanted) {

if (!IsWanted())

return;

- DCHECK(IsWanted());

if (!show_use_counted_) {

show_use_counted_ = true;

RecordMetrics(DownloadActionMetrics::kShown);

}

+ // If the button is wanted, show IPH if possible.

+ static_cast<MediaControlsImpl&>(GetMediaControls())

+ .MaybeDispatchDownloadIPHTrigger();

}

DEFINE_TRACE(MediaControlDownloadButtonElement) {